Fix error on user deletion with reply

[akatsoulas]

No description provided.

[Copilot]

Pull Request Overview

This PR addresses an error encountered during user deletion with reply by updating the logic used to check whether a question is considered taken. Key changes include:

• Revising the is_taken method to include additional conditions for missing or expired tracking fields.
• Removing assertions in favor of a unified condition that resets the fields and saves the object when necessary.

Comments suppressed due to low confidence (2)

kitsune/questions/models.py:710

• [nitpick] The method 'is_taken' performs state mutation by resetting the taker fields and calling self.save(), which is not obvious from its name. Consider renaming the method or updating the documentation to clarify its side-effect behavior.

if self.taken_by is None or self.taken_until is None or self.taken_until < datetime.now():

kitsune/questions/models.py:707

• [nitpick] The updated docstring does not clearly indicate that the method persists changes by calling self.save(). Updating the docstring to explicitly mention this behavior would improve clarity.

If the question is no longer validly taken (due to missing user or expired time), this will reset the database fields and return False.